Play ansible roles on host #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #936 +/- ##
==========================================
+ Coverage 92.19% 92.26% +0.07%
==========================================
Files 6 6
Lines 3037 3078 +41
==========================================
+ Hits 2800 2840 +40
- Misses 237 238 +1
☔ View full report in Codecov by Sentry. |
lhellebr
added
CherryPick
nailgun/entities.py
Outdated
| @@ -4332,6 +4332,25 @@ def bulk_available_incremental_updates(self, synchronous=True, timeout=None, **k | |||
| response = client.post(self.path('bulk/available_incremental_updates'), **kwargs) | |||
| return _handle_response(response, self._server_config, synchronous, timeout) | |||
|
|
|||
| def play_roles(self, synchronous=True, timeout=None, **kwargs): | |||
| """Play all assigned ansible roles | |||
There was a problem hiding this comment.
As same endpoint for both host and host group, so it'd be nice to cover this func for hostgroup too, wdyt?
Suggested change
| """Play all assigned ansible roles | |
| """Play all assigned ansible roles on host |
There was a problem hiding this comment.
It would. I did what I needed for my tests, there's a lot of things that would be nice.
There was a problem hiding this comment.
yup, asked it because its a same endpoint and would be just copy-pasta! :) non-blocking though
Gauravtalreja1
previously approved these changes
Jun 21, 2023
ogajduse
reviewed
Jun 23, 2023
sambible
approved these changes
Jun 27, 2023
JacobCallahan
approved these changes
Jul 3, 2023
This was referenced Jul 3, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jul 3, 2023
* Play ansible roles on host * Coverage * Actually returns task id (cherry picked from commit 995aa7f)
Gauravtalreja1
pushed a commit
that referenced
this pull request
Jul 18, 2023
* Play ansible roles on host * Coverage * Actually returns task id (cherry picked from commit 995aa7f) Co-authored-by: Lukáš Hellebrandt <[email protected]>
This was referenced Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a method to play ansible roles on a host.
Example: